Skip to content

Conversation

mathieubellon
Copy link
Collaborator

Context

Our error message ("Error: Invalid API key.") is too generic. In some cases, it confuses developers, who may suspect that their Git credentials or token are the source of the problem, leading to a costly waste of time.

What has been done

We changed the error strings to be more specific.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (c3d4753) to head (3e399fc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1120   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         144      144           
  Lines        6162     6162           
=======================================
  Hits         5669     5669           
  Misses        493      493           
Flag Coverage Δ
unittests 91.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sevbch
Copy link
Collaborator

sevbch commented Aug 13, 2025

To fix the CI, run this:

  • pre-commit install
  • pre-commit run --all-files

@salome-voltz salome-voltz force-pushed the specific-apitoken-error-message branch from 6092782 to b4dac13 Compare August 13, 2025 15:15
@mathieubellon mathieubellon force-pushed the specific-apitoken-error-message branch from 70b735e to 3e399fc Compare August 13, 2025 15:44
@mathieubellon mathieubellon merged commit 49887e9 into main Aug 14, 2025
51 of 53 checks passed
@mathieubellon mathieubellon deleted the specific-apitoken-error-message branch August 14, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants