Skip to content

Conversation

salome-voltz
Copy link
Collaborator

Context

This MR aims at showing if the secret is in a secret Manager known by GG, by leveraging the new property is_vaulted added in GGshield.

image

PR check list

  • As much as possible, the changes include tests
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry.

@salome-voltz salome-voltz requested a review from a team as a code owner June 9, 2025 13:56
@salome-voltz salome-voltz marked this pull request as draft June 9, 2025 13:57
@salome-voltz salome-voltz self-assigned this Jun 9, 2025
@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5614-show-is_vaulted-in-vs-code-extension branch from ae05444 to dcf4f3e Compare June 9, 2025 16:00
@salome-voltz salome-voltz force-pushed the salomevoltz/scrt-5614-show-is_vaulted-in-vs-code-extension branch from dcf4f3e to 85c4d47 Compare June 9, 2025 16:01
@salome-voltz salome-voltz marked this pull request as ready for review June 9, 2025 16:02
Copy link
Contributor

@sevbch sevbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question: why is "gitguardian" showing up in grey next to the NO in your screenshot?

@salome-voltz
Copy link
Collaborator Author

LGTM! Just one question: why is "gitguardian" showing up in grey next to the NO in your screenshot?

It's a native thing to VS Code, to indicate which extension created the window, it always happens, it's not new to this feature (I agree it's a bit weird...)
image

@salome-voltz salome-voltz merged commit 4203afa into main Jun 10, 2025
5 checks passed
@salome-voltz salome-voltz deleted the salomevoltz/scrt-5614-show-is_vaulted-in-vs-code-extension branch June 10, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants