Add info as a possible value for Severity #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 94.45% 94.53% +0.07%
==========================================
Files 6 6
Lines 830 841 +11
==========================================
+ Hits 784 795 +11
Misses 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ld cause a crash on some incidents
pierrelalanne
force-pushed
the
plalanne/-/fix-typing-issue-on-severity
branch
from
fda11c7 to
4510af2
Compare
chore: add GitHub issue to changelog fragment.
agateau-gg
approved these changes
Nov 7, 2024
Collaborator
agateau-gg
left a comment
agateau-gg
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Just made a tiny change to mention the issue in the changelog fragment.
Collaborator
Author
|
Thanks @agateau-gg, FYI, the fix in ggshield is on its way. Will keep you updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had been forgotten in the original implementation. See corresponding MR in ggshield to use this version of py-gitguardian until a new version is released.
This PR solves #120