feat(models): Add is_diff to ScanResult and diff_kind to PolicyBreak #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walz
force-pushed
the
samuel/spi-526-add-fields-is-diff-and-diff-kind
branch
from
d72e5ad to
1e9de0e
Compare
agateau-gg
requested changes
Nov 13, 2024
Collaborator
agateau-gg
left a comment
agateau-gg
left a comment
There was a problem hiding this comment.
Minor remarks, looks good overall.
Walz
force-pushed
the
samuel/spi-526-add-fields-is-diff-and-diff-kind
branch
from
1e9de0e to
efa3f11
Compare
agateau-gg
approved these changes
Nov 13, 2024
Collaborator
agateau-gg
left a comment
agateau-gg
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
agateau-gg
deleted the
samuel/spi-526-add-fields-is-diff-and-diff-kind
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new fields to the result of scans:
is_difftoScanResultdiff_kindtoPolicyBreak