Skip to content

chore(nhi): add vault related attributes to PoliyBreak model #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

amascia-gg
Copy link
Contributor

Added fields for NNHI ggshield v2

@amascia-gg amascia-gg requested a review from a team as a code owner July 1, 2025 15:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (b1c4bef) to head (8d5661c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   95.59%   95.62%   +0.02%     
==========================================
  Files           5        5              
  Lines        1226     1234       +8     
==========================================
+ Hits         1172     1180       +8     
  Misses         54       54              
Flag Coverage Δ
unittests 95.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amascia-gg amascia-gg force-pushed the amascia/nhi-793/nhi-ggshield-v2 branch from dd58b7a to f2d5bd0 Compare July 2, 2025 08:29
@amascia-gg amascia-gg requested review from sevbch and removed request for sevbch July 2, 2025 08:32
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in changelog, but approved anyway. Feel free to merge when fixed.

@amascia-gg amascia-gg force-pushed the amascia/nhi-793/nhi-ggshield-v2 branch from f2d5bd0 to 8d5661c Compare July 8, 2025 09:01
@amascia-gg amascia-gg changed the title chore(nhi): add vault_path and vault_path_count attributes to PoliyBreak model chore(nhi): add vault related attributes to PoliyBreak model Jul 8, 2025
@amascia-gg amascia-gg merged commit 007c109 into master Jul 9, 2025
19 checks passed
@amascia-gg amascia-gg deleted the amascia/nhi-793/nhi-ggshield-v2 branch July 9, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants