fix: Some list parameters were skipping the default list options #161
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 5 5
Lines 1230 1230
=======================================
Hits 1176 1176
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alustrat-gg
force-pushed
the
alustrat/COR-4373/fix_pagination_parameters
branch
from
b9b389f to
a969b01
Compare
agateau-gg
left a comment
agateau-gg
left a comment
There was a problem hiding this comment.
Looks good, just some debugging left-overs to remove and a changelog entry to add (see CONTRIBUTING.md for details on this).
Also, can you squash your commits?
Alustrat-gg
force-pushed
the
alustrat/COR-4373/fix_pagination_parameters
branch
3 times, most recently
from
dd6eb9e to
92b4b8d
Compare
The Schema we were using for those classes was not mentioning default pagination attributes so they were never rendered. Issue: COR-4373
Alustrat-gg
force-pushed
the
alustrat/COR-4373/fix_pagination_parameters
branch
from
92b4b8d to
0e864a8
Compare
| - pygitguardian/1.18.0 (Darwin;py3.11.8) | ||
| method: GET | ||
| uri: https://api.gitguardian.com/v1/members?access_level=member | ||
| uri: https://api.gitguardian.com/v1/members?cursor=&per_page=20&access_level=member |
There was a problem hiding this comment.
It's weird that we have cursor still present even though exclude_none was specified in the schemas
There was a problem hiding this comment.
It's because the default value for this one is an empty string and not None
The provided Schemas for those parameter classes did not mention the default pagination attributes. Therefore, even if they were passed in the class initialization, they were not passed to the URL.
Issue: COR-4373