Skip to content

Conversation

@kevinbackhouse
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 9, 2025 09:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the automatic creation of logs and data directories from the devcontainer post-creation setup script. While these directories are no longer needed in the devcontainer environment (as they are created by src/run_seclab_agent.sh when running the Docker container), there is a critical issue with the remaining code.

Key Changes

  • Removed mkdir -p logs command from .devcontainer/post-create.sh
  • Removed mkdir -p data command from .devcontainer/post-create.sh
Comments suppressed due to low confidence (1)

.devcontainer/post-create.sh:26

  • The data directory is still referenced on line 24 where CODEQL_DBS_BASE_PATH=$(realpath data) is written to the .env file. Since the data directory is no longer being created by this script, this will fail with an error when realpath is called on a non-existent directory. Consider either:
  1. Creating the data directory before this line, or
  2. Using a different approach that doesn't require the directory to exist (e.g., $(pwd)/data instead of $(realpath data)), or
  3. Removing this line if the environment variable is no longer needed

Note: The data directory is still created in src/run_seclab_agent.sh, but that may not be relevant for the devcontainer setup.

# Create .env file if it doesn't exist
if [ ! -f .env ]; then
    echo "📝 Creating .env template..."
    echo "# Optional: CodeQL database base path" >> .env
    echo "CODEQL_DBS_BASE_PATH=$(realpath data)" >> .env
    echo "⚠️  Please configure the environment or your .env file with required tokens!"
fi

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse kevinbackhouse merged commit 0f22d3f into GitHubSecurityLab:main Dec 10, 2025
12 checks passed
@kevinbackhouse kevinbackhouse deleted the simplify-script branch December 10, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants