Skip to content

Make setUserId accept nullable user id to clear user id. #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Make setUserId accept nullable user id to clear user id. #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firebase-analytics/src/androidMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public actual class FirebaseAnalytics(public val android: com.google.firebase.an
public actual fun setUserProperty(name: String, value: String) {
android.setUserProperty(name, value)
}
public actual fun setUserId(id: String) {
public actual fun setUserId(id: String?) {
android.setUserId(id)
}
public actual fun resetAnalyticsData() {
Expand Down
2 changes: 1 addition & 1 deletion firebase-analytics/src/commonMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public expect fun Firebase.analytics(app: FirebaseApp): FirebaseAnalytics
public expect class FirebaseAnalytics {
public fun logEvent(name: String, parameters: Map<String, Any>? = null)
public fun setUserProperty(name: String, value: String)
public fun setUserId(id: String)
public fun setUserId(id: String?)
public fun setAnalyticsCollectionEnabled(enabled: Boolean)
public fun setSessionTimeoutInterval(sessionTimeoutInterval: Duration)
public suspend fun getSessionId(): Long?
Expand Down
2 changes: 1 addition & 1 deletion firebase-analytics/src/iosMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public actual class FirebaseAnalytics(public val ios: FIRAnalytics.Companion) {
public actual fun setUserProperty(name: String, value: String) {
ios.setUserPropertyString(value, name)
}
public actual fun setUserId(id: String) {
public actual fun setUserId(id: String?) {
ios.setUserID(id)
}
public actual fun resetAnalyticsData() {
Expand Down
2 changes: 1 addition & 1 deletion firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public actual class FirebaseAnalytics(public val js: dev.gitlive.firebase.analyt
dev.gitlive.firebase.analytics.externals.setUserProperty(js, name, value)
}

public actual fun setUserId(id: String) {
public actual fun setUserId(id: String?) {
dev.gitlive.firebase.analytics.externals.setUserId(js, id)
}

Expand Down
2 changes: 1 addition & 1 deletion firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/externals/analytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public external fun getAnalytics(app: FirebaseApp? = definedExternally): Firebas

public external fun logEvent(app: FirebaseAnalytics, name: String, parameters: Map<String, Any>?)
public external fun setUserProperty(app: FirebaseAnalytics, name: String, value: String)
public external fun setUserId(app: FirebaseAnalytics, id: String)
public external fun setUserId(app: FirebaseAnalytics, id: String?)
public external fun resetAnalyticsData(app: FirebaseAnalytics)
public external fun setDefaultEventParameters(app: FirebaseAnalytics, parameters: Map<String, String>)
public external fun setAnalyticsCollectionEnabled(app: FirebaseAnalytics, enabled: Boolean)
Expand Down
2 changes: 1 addition & 1 deletion firebase-analytics/src/jvmMain/kotlin/dev/gitlive/firebase/analytics/analytics.jvm.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public actual fun Firebase.analytics(app: FirebaseApp): FirebaseAnalytics {

public actual class FirebaseAnalytics {
public actual fun setUserProperty(name: String, value: String) {}
public actual fun setUserId(id: String) {}
public actual fun setUserId(id: String?) {}
public actual fun resetAnalyticsData() {}
public actual fun setAnalyticsCollectionEnabled(enabled: Boolean) {}
public actual fun setSessionTimeoutInterval(sessionTimeoutInterval: Duration) {}
Expand Down
Loading