Skip to content

Remove usage of -ktx dependencies #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025

Conversation

ChristianKatzmann
Copy link
Contributor

@ChristianKatzmann ChristianKatzmann commented Jul 16, 2025

Per https://firebase.google.com/docs/android/kotlin-migration

This change means that Kotlin developers can now depend on the main modules instead of the KTX modules (when using Firebase BoM v32.5.0+ or main module versions listed in BoM v32.5.0+).

As this project uses Firebase BoM 33.10.0 this is a safe change.

Resolves #676.

@DatL4g
Copy link

DatL4g commented Jul 30, 2025

@nbransby This is getting urgent, the -ktx dependencies are not maintained anymore.

Latest Common: https://mvnrepository.com/artifact/com.google.firebase/firebase-common/22.0.0
Latest KTX Common: https://mvnrepository.com/artifact/com.google.firebase/firebase-common-ktx/21.0.0

@bpappin
Copy link

bpappin commented Aug 3, 2025

Why is this PR still sitting here after 3 weeks?

@cuub
Copy link

cuub commented Aug 5, 2025

Eager to have this one too.

@DatL4g
Copy link

DatL4g commented Aug 8, 2025

PR Status

I don't think this pull request will get merged soon (if ever).

Even if it would, it will take a couple more weeks (or months, or years?) until it get's released.
The project is too outdated for a simple publish and the maintainer does not invest time into this anymore.

Fork

So I took this thing into my own hands, forked it updated it and applied multiple pending pull requests.
https://github.com/DatL4g/firebase-kotlin-sdk

Take a look at the README to see more information.

The packages are available under the same name and version, just the group changed from dev.gitlive to dev.datlag.firebase

Expect some minor breaking changes (nothing crazy, just imports if you work with platform depending native bindings)
These were mandatory in order to update the project properly.

Ignore the following pings, but since a lot of people are waiting for this, I am making sure everyone sees this.
List of people who commented or liked the PR and Issue:
@ChristianKatzmann @bpappin @cuub @izadiegizabal @SebastianRask @ienground @MaTriXy @MarcelBochtler @AndrazP @shubhamsinghshubham777 @Breens-Mbaka @ayitinya @morhpeus87 @ksharma-xyz @sebaslogen @hiking93

@nbransby nbransby enabled auto-merge August 10, 2025 19:12
@Reedyuk
Copy link
Collaborator

Reedyuk commented Aug 10, 2025

Looks good to me, LGTM

@ChristianKatzmann
Copy link
Contributor Author

@nbransby Thanks for approving this PR and enabling auto-merge. 👍 Unfortunately, some checks seems to hung. Is it somewhat expected for those ios checks to take so long?

@Reedyuk Reedyuk disabled auto-merge August 11, 2025 07:30
@Reedyuk Reedyuk merged commit d4ee35e into GitLiveApp:master Aug 11, 2025
49 checks passed
@ChristianKatzmann ChristianKatzmann deleted the ck/drop_ktx branch August 11, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of ktx dependencies
6 participants