Auth suport action code settings.link domain #741
Closed
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platforms supported: * android * ios * js * NOT jvm
…uport-ActionCodeSettings.linkDomain # Conflicts: # gradle/libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full credit to @https://github.com/treitter this is his pr but i rebase it, as i didnt have permissions to rebase his fork.
This adds the
ActionCodeSettings.linkDomainproperty to support custom domains in auth (overridding the defaultPROJECT_ID.firebaseapp.comauthentication links).This PR should fix issue 731.
Supported platforms:
Unsupported platforms:
I haven't been able to test this since I haven't been able to resolve some issues with
mavenLocal. But this is basically a copy-paste-edit ofdynamicLinkDomainso it should work with, at most, trivial fixes.