Potential fix for code scanning alert no. 8: Information exposure through an exception #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/GitTimeraider/Directadmin-Emailforwarder/security/code-scanning/8
To fix the problem, we should avoid returning the exception message (
str(e)) in the API response. Instead, we should return only a generic error message to the client, while logging the full exception details (including stack trace) on the server for debugging purposes. This can be done by removing the'details': str(e)line from the JSON response in the exception handler for thedelete_forwarderendpoint. No changes to the logging are needed, as the stack trace is already printed to the server logs.What to change:
app/main.py, in thedelete_forwarderfunction, remove the'details': str(e)field from the JSON response in the exception handler (lines 236–239).Suggested fixes powered by Copilot Autofix. Review carefully before merging.