Potential fix for code scanning alert no. 3: Information exposure through an exception #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/GitTimeraider/GithubBackup-docker/security/code-scanning/3
To fix the problem, we should avoid exposing the raw exception message (
str(e)) in API responses. Instead, the error should be logged at the server, and the user should be shown a generic message indicating an internal error. This change must be made in the/api/test-backup/<int:repo_id>endpoint, specifically in the exception handler in lines 542-543. Necessary changes include:return jsonify({'success': False, 'error': str(e)}), 500with a generic message like"An internal error occurred.".logger.error(..., exc_info=True)) is used.No additional imports or dependencies are needed, as logging is already configured.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.