Develop #35
Develop #35
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request implements comprehensive health monitoring and webhook notification functionality for the Subscription Tracker application. It focuses on improving system reliability through Docker health checks and adding a robust webhook system for subscription notifications.
- Docker health checks for application and database containers with appropriate timeouts and retry configurations
- Complete webhook notification system supporting multiple platforms (Discord, Slack, Teams, Gotify, Generic)
- Enhanced form validation for webhook URLs with type-specific validation rules
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Adds health check configurations for web, postgres, and mariadb services |
| app/webhooks.py | New comprehensive webhook system with multiple platform support and notification functionality |
| app/forms.py | Enhances webhook URL validation using the new webhooks module |
| TIMEOUT_FIX.md | Removes obsolete timeout fix documentation |
| Dockerfile | Adds curl dependency and health check configuration for the web container |
| DATABASE_SETUP.md | New comprehensive database and health monitoring documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| response.raise_for_status() | ||
|
|
||
| # Update last_used timestamp | ||
| self.webhook.last_used = datetime.utcnow() |
There was a problem hiding this comment.
Using datetime.utcnow() is deprecated in Python 3.12+. Consider using datetime.now(timezone.utc) for timezone-aware UTC timestamps.
|
|
||
| embed = { | ||
| "description": message, | ||
| "timestamp": datetime.utcnow().isoformat(), |
There was a problem hiding this comment.
Using datetime.utcnow() is deprecated in Python 3.12+. Consider using datetime.now(timezone.utc) for timezone-aware UTC timestamps.
| def prepare_payload(self, message: str, title: str = None, color: str = None) -> Dict[str, Any]: | ||
| payload = { | ||
| "text": message, | ||
| "timestamp": datetime.utcnow().isoformat() |
There was a problem hiding this comment.
Using datetime.utcnow() is deprecated in Python 3.12+. Consider using datetime.now(timezone.utc) for timezone-aware UTC timestamps.
|
|
||
| attachment = { | ||
| "text": message, | ||
| "ts": int(datetime.utcnow().timestamp()), |
There was a problem hiding this comment.
Using datetime.utcnow() is deprecated in Python 3.12+. Consider using datetime.now(timezone.utc) for timezone-aware UTC timestamps.
Fixes for healthcheck and webhooks