Timezone fix #38
Merged
Timezone fix #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses timezone compatibility issues in the currency exchange rate system by introducing a helper function to ensure datetime objects are timezone-aware before performing time calculations.
- Added
ensure_timezone_aware()helper function to handle naive datetime objects - Updated age calculation logic to use timezone-aware datetimes consistently
- Applied timezone fixes to both primary and fallback provider cache age calculations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ERAPI_URL = "https://open.er-api.com/v6/latest/EUR" | ||
|
|
||
|
|
||
| def ensure_timezone_aware(dt, default_tz=timezone.utc): |
There was a problem hiding this comment.
The function parameter dt should be documented with its expected type in the docstring for better API clarity.
| """ | ||
| Ensure a datetime object is timezone-aware. | ||
| If naive, assume it's in the default timezone (UTC by default). | ||
| """ |
There was a problem hiding this comment.
Missing input validation for the dt parameter. The function should handle cases where dt is None or not a datetime object to prevent AttributeError.
Suggested change
| """ | |
| """ | |
| if dt is None: | |
| raise ValueError("dt cannot be None") | |
| if not isinstance(dt, datetime): | |
| raise TypeError(f"dt must be a datetime object, got {type(dt).__name__}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.