Skip to content

Commit 79b3974

Browse files
committed
Simplified generate members function
1 parent 42e0e82 commit 79b3974

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

src/GitVersionTask/AssemblyInfoBuilder/AssemblyInfoBuilder.cs

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
using System.Collections.Generic;
1+
using System;
2+
using System.Collections.Generic;
23
using System.Linq;
3-
using System.Text;
4-
54
using GitVersion;
65

76
public class AssemblyInfoBuilder
87
{
98
public string GetAssemblyInfoText(VersionVariables vars, string assemblyName)
109
{
11-
var v = vars.ToArray();
10+
var v = vars.ToList();
1211

1312
var assemblyInfo = string.Format(
1413
@"using System;
@@ -72,18 +71,6 @@ static string GenerateAttributeVariableMembers(IList<KeyValuePair<string, string
7271

7372
static string GenerateMembers(IList<KeyValuePair<string, string>> vars, string memberFormat)
7473
{
75-
var members = new StringBuilder();
76-
for (var i = 0; i < vars.Count; i++)
77-
{
78-
var variable = vars[i];
79-
members.AppendFormat(memberFormat, variable.Key, variable.Value);
80-
81-
if (i < vars.Count - 1)
82-
{
83-
members.AppendLine();
84-
}
85-
}
86-
87-
return members.ToString();
74+
return string.Join(Environment.NewLine, vars.Select(v => string.Format(memberFormat, v.Key, v.Value)));
8875
}
8976
}

0 commit comments

Comments
 (0)