(build) fixed publishing of nuget packages to GitHub packages Repo

Author: arturcic

.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
       - uses: actions/[email protected]
       - uses: peter-evans/[email protected]
         with:
-          token: ${{ secrets.RELEASE_GITHUB_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}
           repository: ${{ github.repository }}
           event-type: release
           client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}'

build/publish/BuildLifetime.cs

@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System;
 using Cake.Common.IO;
 using Common.Utilities;
 using Publish.Utilities;
@@ -15,13 +15,12 @@ public override void Setup(BuildContext context)
             if (context.Version?.NugetVersion != null)
             {
                 var nugetVersion = context.Version.NugetVersion;
-                context.Packages = new List<NugetPackage>();
 
                 var nugetPackagesFiles = context.GetFiles(Paths.Nuget + "/*.nupkg");
                 foreach (var packageFile in nugetPackagesFiles)
                 {
                     var packageName = packageFile.GetFilenameWithoutExtension().ToString()[..^(nugetVersion.Length + 1)].ToLower();
-                    context.Packages.Add(new NugetPackage(packageName, packageFile, packageName.Contains("Portable")));
+                    context.Packages.Add(new NugetPackage(packageName, packageFile, packageName.Contains("Portable", StringComparison.OrdinalIgnoreCase)));
                 }
             }
             context.StartGroup("Build Setup");