simplify ReleaseDateFinder

Author: SimonCropp

GitVersionCore/ReleaseDateFinder.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.Linq;
 using LibGit2Sharp;
 
@@ -28,13 +27,12 @@ public static ReleaseDate Execute(IRepository repo, Commit commit, int calculate
             }
 
             var vp = FindLatestStableTaggedCommitReachableFrom(repo, commit);
-            var latestStable = repo.Lookup<Commit>(vp.CommitSha);
-            rd.OriginalDate = latestStable.When();
-            rd.OriginalCommitSha = vp.CommitSha;
+            rd.OriginalDate = vp.When();
+            rd.OriginalCommitSha = vp.Sha;
             return rd;
         }
 
-        static VersionPoint FindLatestStableTaggedCommitReachableFrom(IRepository repo, Commit commit)
+        static Commit FindLatestStableTaggedCommitReachableFrom(IRepository repo, Commit commit)
         {
             var masterTip = repo.FindBranch("master").Tip;
             var ancestor = repo.Commits.FindMergeBase(masterTip, commit);
@@ -59,7 +57,7 @@ static VersionPoint FindLatestStableTaggedCommitReachableFrom(IRepository repo,
             return null;
         }
 
-        static VersionPoint RetrieveStableVersionPointFor(IEnumerable<Tag> allTags, Commit c)
+        static Commit RetrieveStableVersionPointFor(IEnumerable<Tag> allTags, Commit c)
         {
             var tags = allTags
                 .Where(tag => tag.PeeledTarget() == c)
@@ -80,7 +78,7 @@ static VersionPoint RetrieveStableVersionPointFor(IEnumerable<Tag> allTags, Comm
             var stableTag = tags.Single();
             var commit = RetrieveMergeCommit(stableTag);
 
-            return BuildFrom(stableTag, commit);
+            return commit;
         }
 
         static bool IsStableRelease(string tagName)
@@ -101,21 +99,6 @@ static Commit RetrieveMergeCommit(Tag stableTag)
             throw new WarningException(message);
         }
 
-        static VersionPoint BuildFrom(Tag stableTag, Commit commit)
-        {
-            ShortVersion shortVersion;
-
-            var hasParsed = ShortVersionParser.TryParseMajorMinor(stableTag.Name, out shortVersion);
-            Debug.Assert(hasParsed);
-
-            return new VersionPoint
-            {
-                Major = shortVersion.Major,
-                Minor = shortVersion.Minor,
-                CommitSha = commit.Id.Sha,
-            };
-        }
-
 
     }
 }