Fixes to dev container #4403
Merged
Fixes to dev container #4403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use git version from OS to avoid compiling newest version from source -> saves quite some time
the SDK version is defined as v9.0 in global.json and hence it shows that NET 9.0 is missing in the dotnet v8.0 container compiling and running the tests works now: dotnet test --framework net9.0 src/
Member
|
@Bi0T1N thank you for the updates, nowadays I use less devcontainer for GitVersion but glad there is still interest in this |
Contributor
|
Thank you @Bi0T1N for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One change avoids compiling git from source since the version provided by the OS is fine and can be installed quickly (compared to compiling git). The other one addresses the problem that the
dotnet:dev-8.0doesn't work out-of-the-box because theglobal.jsondefines SDK 9.0 (not sure if this is the problem but my changes fixed the issue and got the devcontainer running) so that you needdotnet:dev-9.0.Motivation and Context
Better out-of-the-box experience.
How Has This Been Tested?
Setting up the project in VS Code and running the testsuite with
dotnet test --framework net9.0 src/Checklist: