Skip to content

Support "objectivec" as alias for Objective C syntax #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregberge
Copy link
Contributor

The block model from GitBook uses "objectivec" instead of "objective-c",
so we support it.

Copy link

linear bot commented Aug 12, 2025

Copy link

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: 5c5a23a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for "objectivec" as an alias for Objective-C syntax highlighting to maintain compatibility with GitBook's block model, which uses "objectivec" instead of the standard "objective-c" identifier.

  • Adds a new syntax alias mapping "objectivec" to "objective-c" in the highlight configuration
  • Includes a changeset documenting this patch-level change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/gitbook/src/components/DocumentView/CodeBlock/highlight.ts Adds the "objectivec" alias mapping to support GitBook's naming convention
.changeset/chatty-rivers-move.md Documents the patch-level change for release notes

Copy link

argos-ci bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 34 changed Aug 13, 2025, 11:30 AM
v2-cloudflare (Inspect) ✅ No changes detected - Aug 13, 2025, 11:35 AM
v2-vercel (Inspect) 👍 Changes approved 1 changed Aug 13, 2025, 11:34 AM

The block model from GitBook uses "objectivec" instead of "objective-c",
so we support it.
@gregberge gregberge force-pushed the greg/rnd-7882-rendered-objective-c-code-blocks-dont-have-syntax branch from e19c452 to 5c5a23a Compare August 13, 2025 11:24
@gregberge gregberge merged commit d655d3e into main Aug 13, 2025
16 checks passed
@gregberge gregberge deleted the greg/rnd-7882-rendered-objective-c-code-blocks-dont-have-syntax branch August 13, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants