Improve vertical alignment of site items and fix floating page aside #3560
+223
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cc4e427 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
conico974
approved these changes
Aug 12, 2025
…-and-ask-dropdowns-is
zenoachtig
deleted the
zeno/rnd-7873-alignment-between-on-this-page-and-ask-dropdowns-is
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical alignment of items on the site had grown inconsistent. This PR standardises the height again, and simplies the layout logic of the
PageAsidemenu, especially in its floating mode (only used on OpenAPI pages).Demo
Vertical alignment
Cleaned up the vertical alignment of the TOC, page header incl. page actions dropdown, and the page sidebar.
Before → After (ignore the header logo size, that's because of local vs prod image hosting)
PageAsidemenuThe page's aside menu has improved sticky behaviour and better scroll containers, along with better vertical alignment with the rest of the site.
Before → After (ignore the header logo size, that's because of local vs prod image hosting)
Floating
PageAsideGave slightly more horizontal room and improves the scrolling and layout of the floating menu.
Before → After (ignore the header logo size, that's because of local vs prod image hosting)
Floating
PageAsideoffset bugFix a bug where the menu offset would not take into account the presence of an announcement banner
Before → After (ignore the header logo size, that's because of local vs prod image hosting)