Add "original" color step and apply to bg-primary-solid elements
#3618
+21
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f953585 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our colour system, we standardise on perceived brightness in order to have readable contrast no matter which colour you pick.
We have an exception for step 9 of the scale (which is used for the main branding elements, like buttons or primary text) to use the chosen colour exactly unless it is wildly off the mark in terms of readability. In some cases, specifically shades of yellow, the contrast is often too low and is replaced with a more contrasting colour. This results in some pretty dark-looking UI elements for buttons and steppers.
This PR introduces an extra colour step for backgrounds,
bg-*-original, which will always be the originally chosen colour. The existingbg-*-solidremains available for use cases where the colour should be guaranteed to be readable.