Skip to content

Conversation

gregberge
Copy link
Contributor

@gregberge gregberge commented Oct 16, 2025

CleanShot 2025-10-16 at 16 34 59@2x

Copy link

linear bot commented Oct 16, 2025

Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: e7e8742

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for rendering emojis in document outlines by introducing a new function that returns React nodes instead of plain text strings.

Key changes:

  • Added getNodeReactText() function to handle emoji rendering in document sections
  • Updated DocumentSection.title type from string to ReactNode
  • Replaced getNodeText() calls with getNodeReactText() where emoji support is needed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/gitbook/src/lib/document.tsx Added new getNodeReactText() function to convert document nodes to React nodes with emoji support
packages/gitbook/src/lib/document-sections.ts Updated section title type to ReactNode and switched to using getNodeReactText() for title extraction

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

argos-ci bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 2 changed Oct 16, 2025, 9:27 PM
v2-cloudflare (Inspect) 👍 Changes approved 4 changed Oct 16, 2025, 9:29 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Oct 16, 2025, 9:29 PM

@gregberge gregberge merged commit 6feb8fc into main Oct 16, 2025
16 checks passed
@gregberge gregberge deleted the greg/rnd-8425-misleading-when-adding-emoji-to-the-header-they-are branch October 16, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants