-
Notifications
You must be signed in to change notification settings - Fork 4k
Support emojis in outline #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support emojis in outline #3734
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for rendering emojis in document outlines by introducing a new function that returns React nodes instead of plain text strings.
Key changes:
- Added
getNodeReactText()
function to handle emoji rendering in document sections - Updated
DocumentSection.title
type fromstring
toReactNode
- Replaced
getNodeText()
calls withgetNodeReactText()
where emoji support is needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/gitbook/src/lib/document.tsx | Added new getNodeReactText() function to convert document nodes to React nodes with emoji support |
packages/gitbook/src/lib/document-sections.ts | Updated section title type to ReactNode and switched to using getNodeReactText() for title extraction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
ac09ae6
to
26dcf3e
Compare
26dcf3e
to
7dc8ea3
Compare
Uh oh!
There was an error while loading. Please reload this page.