Skip to content

Conversation

valentin0h
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 65a7006

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@gitbook/integration-googleanalytics Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@clairechabas clairechabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look and asked a question but can't approve since I'm not familiar with integrations configuration in this repo.

description: Look for this in your Google Analytics account.
required:
- tracking_id
componentId: config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: why are we replacing the tracking id with a component id?

Could we add a title and description to it to clarify its role and use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look here for more context.

We're replacing the way we render the configuration. From controlled by declarative + controlled by gitbook-x to controlled by the integration completely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants