-
Notifications
You must be signed in to change notification settings - Fork 76
Ahrefs Web Analytics integration #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2bf737a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Few comments before we can merge it :)
Co-authored-by: Taran Vohra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just applied suggestions from code review. I think we should refrain from using js.dataset['data-key']
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lockfile is broken. Can you fix that?
commit: |
Any chance this pull request will be merged? I'd really like to integrate my Gitbook site with Ahrefs. |
Hey @guillermocalvo, can you address the CI issues? Some weird github setting that didn't run the workflows before. |
@taranvohra Hi, I just fixed the formatting issue (missing semicolon). About the second one, it's related to the way 1Password is set up internally. Since I'm not a member of the @GitbookIO organization, I'm afraid I can't do anything to solve that. By the way, I believe the reason why workflows don't run on this PR is because I have no permissions and they have to be manually approved by some team member. |
Close: #773
Hopefully, this serves as a starting point for the requested Ahrefs integration. I haven't tested it thoroughly, so feel free to amend this PR if needed or close it altogether if you'd rather not pursue this integration.