Skip to content

Conversation

guillermocalvo
Copy link
Contributor

Close: #773

Hopefully, this serves as a starting point for the requested Ahrefs integration. I haven't tested it thoroughly, so feel free to amend this PR if needed or close it altogether if you'd rather not pursue this integration.

Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 2bf737a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@gitbook/integration-ahrefs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@guillermocalvo guillermocalvo marked this pull request as ready for review April 9, 2025 09:50
Copy link
Member

@taranvohra taranvohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Few comments before we can merge it :)

Copy link
Contributor Author

@guillermocalvo guillermocalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just applied suggestions from code review. I think we should refrain from using js.dataset['data-key'] though.

Copy link
Member

@taranvohra taranvohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lockfile is broken. Can you fix that?

@guillermocalvo guillermocalvo requested a review from taranvohra July 2, 2025 15:29
Copy link

pkg-pr-new bot commented Jul 3, 2025

Open in StackBlitz

bun add https://pkg.pr.new/GitbookIO/integrations/@gitbook/api@774

commit: 2bf737a

@guillermocalvo
Copy link
Contributor Author

Any chance this pull request will be merged? I'd really like to integrate my Gitbook site with Ahrefs.
CC @taranvohra @jpreynat Thanks!

@taranvohra
Copy link
Member

taranvohra commented Aug 19, 2025

Hey @guillermocalvo, can you address the CI issues? Some weird github setting that didn't run the workflows before.

@guillermocalvo
Copy link
Contributor Author

@taranvohra Hi, I just fixed the formatting issue (missing semicolon).

About the second one, it's related to the way 1Password is set up internally. Since I'm not a member of the @GitbookIO organization, I'm afraid I can't do anything to solve that.

By the way, I believe the reason why workflows don't run on this PR is because I have no permissions and they have to be manually approved by some team member.

@taranvohra taranvohra merged commit aca0fcd into GitbookIO:main Aug 26, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request integration with Ahrefs web analytics
2 participants