Skip to content

Conversation

@Githubguy132010
Copy link
Owner

This pull request includes several improvements to the build process in the .github/workflows/build.yml file. The changes focus on enhancing error handling, ensuring directory creation, and improving the reliability of the build and release notes generation.

Enhancements to error handling and reliability:

  • Added error handling for Docker image build, ISO build, and package tracking script execution to ensure proper error messages are logged and the workflow exits gracefully if any step fails. [1] [2]
  • Ensured the package cache directory and package tracking output directory are created before use to prevent potential errors. [1] [2]
  • Added verification for the existence of the ISO file and the release notes file, with appropriate fallback content creation if they are missing or empty. [1] [2]

These changes aim to make the build process more robust and provide clearer feedback in case of failures.

@Githubguy132010 Githubguy132010 requested a review from Copilot April 5, 2025 11:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/build.yml:96

  • The use of 'shell' after the image name is unusual; if the container is meant to execute a bash script, consider using 'bash -c' for consistency or confirm that the image's entrypoint supports the 'shell' command.
arch-iso-builder shell "cd ${{ env.WORKSPACE }} && ./scripts/package_tracking/track_package_updates.sh" || {

@Githubguy132010 Githubguy132010 merged commit 9bf1476 into main Apr 5, 2025
2 checks passed
@Githubguy132010 Githubguy132010 deleted the dev branch April 5, 2025 11:06
@Githubguy132010 Githubguy132010 restored the dev branch April 5, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants