feat: Add Docker container with GUI for building ISO #147
Conversation
This commit introduces a new way to build the Arch Linux ISO using a web-based graphical user interface (GUI). The new functionality is provided as a Docker container that runs a simple Flask application. The GUI allows users to start the ISO build process with a single click, view real-time build logs, and download the generated ISO directly from their web browser. Key changes include: - `app.py`: A new Flask application that serves the web interface and orchestrates the build process. - `templates/index.html`: The HTML and JavaScript for the web GUI. - `Dockerfile.gui`: A new Dockerfile to build the container image for the GUI application. - `README.md`: Updated documentation with instructions on how to use the new GUI build method.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@google-labs-jules Code looks good, but I can't test it myself due to me being on Windows on ARM. Can you also add a Github Actions workflow to test the app? |
I've added a GitHub Actions workflow to test the GUI build, as you requested. This will ensure that the feature is automatically tested on future pull requests. |
This commit adds a new GitHub Actions workflow to automatically test the GUI build process. The workflow builds the Docker image for the GUI, runs the container, and uses curl to verify that the web server is responding correctly. This addresses the feedback from the pull request and ensures that the GUI functionality is tested in CI.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
@google-labs-jules Also test the app itself. Like testing the ISO build and download. |
I've updated the GitHub Actions workflow to perform a more comprehensive test, as you suggested. The workflow now triggers an ISO build, waits for it to complete, verifies that the ISO file is created, and checks the download endpoint. This should provide better test coverage for the GUI application. |
This commit enhances the GitHub Actions workflow for the GUI build test. The workflow now performs a more comprehensive end-to-end test: - It triggers the ISO build via the GUI's API endpoint. - It waits for the build to complete successfully. - It verifies that the ISO file has been created. - It tests the download endpoint to ensure the ISO is served correctly. This addresses the feedback from the pull request to provide more robust testing of the GUI application's core functionality.
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
dosubot
bot
added
the
size:L
This change adds a new Docker container that provides a web-based GUI for creating the ISO. The GUI is built with Flask and allows users to start the build, see live logs, and download the ISO. The
README.mdhas been updated to include instructions for this new feature. This provides a more user-friendly alternative to the existing command-line build process.