Thanks clippy #69
Merged
Thanks clippy #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies some changes recommended by clippy that have caused the clippy check to start failingo on CI as in: https://github.com/EliahKagan/cargo-smart-release/actions/runs/16672703924/job/47192391862 This was done by running `cargo clippy --fix` followed by `cargo fmt` and inspecting the result.
Clippy has begun to disapprove of such uses that can be expressed no less complicatedly with `if`-`then`, but while it was able to detect this one like the others, it was not able to auto-fix it. A direct refactoring might use `Default::default()`, but `"".into()` seems slightly more readable here for showing the effect on the message that gets built into the log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies some changes recommended by clippy that have caused the clippy check to start failing on CI as in:
https://github.com/EliahKagan/cargo-smart-release/actions/runs/16672703924/job/47192391862
This was done by running
cargo clippy --fixfollowed bycargo fmtand inspecting the result.Based on EliahKagan#24, it looks like the new clippy errors (due to using a newer Rust toolchain) may be all that will need to be fixed for the forthcoming Dependabot grouped version update PR, and that nothing updated in that PR should itself break. But that is not certain, and the PR should be examined once opened.
Edit: Yes, this kept #70 from having any CI failures.