feat: handle ReflogLookup::Date #1645
Conversation
|
also just realized my min_by logic is wrong since it only deal with values smaller than the target date I think |
|
Hmm I see there is an implementation for to_time in gix_date however this is not public should I just implement Sub for Time where the Output is i64? |
dvtkrlbs
force-pushed
the
refloglookup-date
branch
5 times, most recently
from
dafe686 to
0187a55
Compare
| return None; | ||
| } | ||
| }, | ||
| }; |
There was a problem hiding this comment.
question since this is duplicated with the other part should I create a closure. This duplication is probably fine but it kinda bothers me.
There was a problem hiding this comment.
Refactor at will, but please do so in a separate commit.
dvtkrlbs
force-pushed
the
refloglookup-date
branch
2 times, most recently
from
e118f9f to
6b26435
Compare
|
Is this ready for review? |
|
hey sorry was not able to test it properly since I am not actually knowledgable about the internals of git that much. I would appreaciate if someone would test it since they would do it better than me. |
|
Thanks for letting me know - I will take care of it, hopefully so this PR is merged before next year. |
Byron
force-pushed
the
refloglookup-date
branch
from
6b26435 to
3f5c117
Compare
Byron
force-pushed
the
refloglookup-date
branch
from
3f5c117 to
1bb5f7d
Compare
…ure don't hurt signature parsing.
…be read. Otherwise, the revlog iteration may stop unexpectedly on long lines.
- deduplicate implementation - fix implementation to work just like Git does (according to their source code) - add tests
Byron
force-pushed
the
refloglookup-date
branch
from
1bb5f7d to
9662bc1
Compare
2 participants
Handles the missing Date based reflog lookup. The target date is compared against the signature time field. This is my first contribution and was kinda a blind one so open to some guidance (especially on testing this addition)