Fix tests when GIT_AUTHOR_NAME or GIT_COMMITTER_NAME are set
#1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests failed to unset these variables, so they'd fail in an environment with these variables set (such as on a developer system that sets them).
Byron
force-pushed
the
fix-tests-in-environments-with-env-variables-set
branch
from
92dd1b1 to
94dda22
Compare
Byron
approved these changes
Mar 15, 2025
joshtriplett
deleted the
fix-tests-in-environments-with-env-variables-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests failed to unset these variables, so they'd fail in an
environment with these variables set (such as on a developer system that
sets them).