Don’t change semantic behaviour based on debug_assertions

gitoxide-core/src/repository/config.rs

@@ -13,10 +13,7 @@ pub fn list(
     if format != OutputFormat::Human {
         bail!("Only human output format is supported at the moment");
     }
-    let repo = gix::open_opts(
-        repo.git_dir(),
-        repo.open_options().clone().lossy_config(false).cli_overrides(overrides),
-    )?;
+    let repo = gix::open_opts(repo.git_dir(), repo.open_options().clone().cli_overrides(overrides))?;
     let config = repo.config_snapshot();
     if let Some(frontmatter) = config.frontmatter() {
         for event in frontmatter {

gix-transport/Cargo.toml

@@ -47,6 +47,8 @@ http-client-reqwest-rust-tls-trust-dns = [
 ]
 ## Stacks with `blocking-http-transport-reqwest` and enables `https://` via the `native-tls` crate.
 http-client-reqwest-native-tls = ["http-client-reqwest", "reqwest/default-tls"]
+## Allows sending credentials over cleartext HTTP. For testing purposes only.
+http-client-insecure-credentials = []
 ## If set, an async implementations of the git transports becomes available in `crate::client`.
 ## Suitable for implementing your own transports while using git's way of communication, typically in conjunction with a custom server.
 ## **Note** that the _blocking_ client has a wide range of available transports, with the _async_ version of it supporting only the TCP based `git` transport leaving you
@@ -66,12 +68,12 @@ serde = ["dep:serde"]
 [[test]]
 name = "blocking-transport"
 path = "tests/blocking-transport.rs"
-required-features = ["blocking-client", "maybe-async/is_sync"]
+required-features = ["blocking-client", "http-client-insecure-credentials", "maybe-async/is_sync"]
 
 [[test]]
 name = "blocking-transport-http-only"
 path = "tests/blocking-transport-http.rs"
-required-features = ["http-client-curl", "maybe-async/is_sync"]
+required-features = ["http-client-curl", "http-client-insecure-credentials", "maybe-async/is_sync"]
 
 [[test]]
 name = "async-transport"

gix-transport/src/client/blocking_io/http/mod.rs

@@ -297,7 +297,7 @@ impl<H: Http> Transport<H> {
     #[allow(clippy::unnecessary_wraps, unknown_lints)]
     fn add_basic_auth_if_present(&self, headers: &mut Vec<Cow<'_, str>>) -> Result<(), client::Error> {
         if let Some(gix_sec::identity::Account { username, password }) = &self.identity {
-            #[cfg(not(debug_assertions))]
+            #[cfg(not(feature = "http-client-insecure-credentials"))]
             if self.url.starts_with("http://") {
                 return Err(client::Error::AuthenticationRefused(
                     "Will not send credentials in clear text over http",

gix/src/config/cache/incubate.rs

@@ -11,7 +11,7 @@ pub(crate) struct StageOne {
     pub buf: Vec<u8>,
 
     pub is_bare: bool,
-    pub lossy: Option<bool>,
+    pub lossy: bool,
     pub object_hash: gix_hash::Kind,
     pub reflog: Option<gix_ref::store::WriteReflog>,
     pub precompose_unicode: bool,
@@ -24,7 +24,7 @@ impl StageOne {
         common_dir: &std::path::Path,
         git_dir: &std::path::Path,
         git_dir_trust: gix_sec::Trust,
-        lossy: Option<bool>,
+        lossy: bool,
         lenient: bool,
     ) -> Result<Self, Error> {
         let mut buf = Vec::with_capacity(512);
@@ -109,7 +109,7 @@ fn load_config(
     buf: &mut Vec<u8>,
     source: gix_config::Source,
     git_dir_trust: gix_sec::Trust,
-    lossy: Option<bool>,
+    lossy: bool,
     lenient: bool,
 ) -> Result<gix_config::File<'static>, Error> {
     let metadata = gix_config::file::Metadata::from(source)

gix/src/config/cache/util.rs

@@ -16,9 +16,9 @@ pub(crate) fn interpolate_context<'a>(
     }
 }
 
-pub(crate) fn base_options(lossy: Option<bool>, lenient: bool) -> gix_config::file::init::Options<'static> {
+pub(crate) fn base_options(lossy: bool, lenient: bool) -> gix_config::file::init::Options<'static> {
     gix_config::file::init::Options {
-        lossy: lossy.unwrap_or(!cfg!(debug_assertions)),
+        lossy,
         ignore_io_errors: lenient,
         ..Default::default()
     }

gix/src/open/mod.rs

@@ -29,7 +29,7 @@ pub struct Options {
     pub(crate) git_dir_trust: Option<gix_sec::Trust>,
     /// Warning: this one is copied to config::Cache - don't change it after repo open or keep in sync.
     pub(crate) filter_config_section: Option<fn(&gix_config::file::Metadata) -> bool>,
-    pub(crate) lossy_config: Option<bool>,
+    pub(crate) lossy_config: bool,
     pub(crate) lenient_config: bool,
     pub(crate) bail_if_untrusted: bool,
     pub(crate) api_config_overrides: Vec<BString>,

gix/src/open/options.rs

@@ -10,7 +10,7 @@ impl Default for Options {
             permissions: Default::default(),
             git_dir_trust: None,
             filter_config_section: None,
-            lossy_config: None,
+            lossy_config: false,
             lenient_config: true,
             bail_if_untrusted: false,
             open_path_as_is: false,
@@ -120,13 +120,12 @@ impl Options {
         self
     }
 
-    /// By default, in release mode configuration will be read without retaining non-essential information like
-    /// comments or whitespace to optimize lookup performance.
+    /// If set, default is false, configuration will be read without retaining non-essential information like comments
+    /// or whitespace to optimize lookup performance.
     ///
-    /// Some application might want to toggle this to false in they want to display or edit configuration losslessly
-    /// with all whitespace and comments included.
+    /// This will prevent displaying or editing configuration losslessly.
     pub fn lossy_config(mut self, toggle: bool) -> Self {
-        self.lossy_config = toggle.into();
+        self.lossy_config = toggle;
         self
     }
 
@@ -163,7 +162,7 @@ impl gix_sec::trust::DefaultForLevel for Options {
                 permissions: Permissions::default_for_level(level),
                 git_dir_trust: gix_sec::Trust::Full.into(),
                 filter_config_section: Some(config::section::is_trusted),
-                lossy_config: None,
+                lossy_config: false,
                 bail_if_untrusted: false,
                 lenient_config: true,
                 open_path_as_is: false,
@@ -179,7 +178,7 @@ impl gix_sec::trust::DefaultForLevel for Options {
                 bail_if_untrusted: false,
                 lenient_config: true,
                 open_path_as_is: false,
-                lossy_config: None,
+                lossy_config: false,
                 api_config_overrides: Vec::new(),
                 cli_config_overrides: Vec::new(),
                 current_dir: None,