Bump prodash (unifying bytesize version) and other dependencies #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the cargo group with 3 updates: [clap](https://github.com/clap-rs/clap), [prodash](https://github.com/Byron/prodash) and [rustix](https://github.com/bytecodealliance/rustix). Updates `clap` from 4.5.35 to 4.5.36 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.35...clap_complete-v4.5.36) Updates `prodash` from 29.0.1 to 29.0.2 - [Release notes](https://github.com/Byron/prodash/releases) - [Changelog](https://github.com/Byron/prodash/blob/main/CHANGELOG.md) - [Commits](GitoxideLabs/prodash@v29.0.1...v29.0.2) Updates `rustix` from 1.0.3 to 1.0.5 - [Release notes](https://github.com/bytecodealliance/rustix/releases) - [Changelog](https://github.com/bytecodealliance/rustix/blob/main/CHANGES.md) - [Commits](bytecodealliance/rustix@v1.0.3...v1.0.5) --- updated-dependencies: - dependency-name: clap dependency-version: 4.5.36 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo - dependency-name: prodash dependency-version: 29.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo - dependency-name: rustix dependency-version: 1.0.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
EliahKagan
changed the title
EliahKagan
changed the title
EliahKagan
approved these changes
Apr 13, 2025
There was a problem hiding this comment.
This updates prodash to a version that has GitoxideLabs/prodash#33, so bytesize is major version 2 everywhere in gitoxide (both directly and through prodash). It also takes some small bugfixes in other dependencies.
To make sure the progress display still looks okay, I've tested this with commands like this, on Arch Linux:
cargo run --bin=gix -- clone https://github.com/GitoxideLabs/gitoxide.gitIt looks the same, presumably because, for units based on bytes, the main unit is "MB/s", where the symbol "MB" has not changed across bytesize versions. (And it was, and remains, the decimal SI unit.)
In principle, it could break on Windows in a way that none of this testing would reveal. I don't have the ability to test it on Windows at the moment. However, the likelihood of such a breakage (since prodash itself did not change in how it displays anything) is very low.
Since the prodash bump itself is a patch release, that we re-export it doesn't seem like it has any special associated versioning considerations. (That's different from bytesize; my concern in #1952 remains, I just don't think anything special should be done in this PR related to it.)
Comment on lines
-436
to
-440
| [[package]] | ||
| name = "bytesize" | ||
| version = "1.3.3" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "2e93abca9e28e0a1b9877922aacb20576e05d4679ffa78c3d6dc22a26a216659" |
There was a problem hiding this comment.
The old version is now gone from the dependency tree, as intended.
|
@dependabot merge |
|
Unfortunately the customized title didn't make it anywhere into the merge commit message, because I used |
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Apr 14, 2025
`gix-features` republishes `bytesize`, which has been bumped from major version 1 to major version 2. Because the interface of `bytesize` is effectively part of that of `gix-features` due to the explicitly republication of the `bytesize` module in full with no caveats, this is effectively a breaking change in `gix-features` as well, though many callers may not be substantially affected. Major changes that may affect some callers that use `bytesize` through `gix-features` include the removal of the top-level `bytesize::to_string()` function, the change in default behavior from displaying decimal SI units to displaying binary IEC units (though all or most gitoxide-related creates, in adapting to the changes, have thus far opted to continue using decimal SI units), and the small but UI-facing change that decimal SI kilobytes (units of 1000 bytes) are given with the symbol "kB" rather than the more ambiguous (and arguably less accurate) symbol "KB". In addition to republishing `bytesize`, `gix-features` also republishes `prodash`. Futhermore, some uses of `bytesize` are transitively through `prodash`, which itself has recently received an update to use `bytesize` major version 2. (Since `prodash` does not republish `bytesize`, that is not considered to be a breaking change in `prodash` itself.) To get the benefits of the newer version of `bytesize` while avoiding new inconsistencies, and also to avoid depending on multiple versions of `bytesize`, the `prodash` dependency version has also been upgraded. For more information, see: - GitoxideLabs#1952 - https://github.com/bytesize-rs/bytesize/releases/tag/bytesize-v2.0.0 - GitoxideLabs#1949 - GitoxideLabs/prodash#33 - GitoxideLabs#1953
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Apr 14, 2025
`gix-features` republishes `bytesize`, which has been bumped from major version 1 to major version 2. Because the interface of `bytesize` is effectively part of that of `gix-features` due to the explicitly republication of the `bytesize` module in full with no caveats, this is effectively a breaking change in `gix-features` as well, though many callers may not be substantially affected. Major changes that may affect some callers that use `bytesize` through `gix-features` include the removal of the top-level `bytesize::to_string()` function, the change in default behavior from displaying decimal SI units to displaying binary IEC units (though all or most gitoxide-related creates, in adapting to the changes, have thus far opted to continue using decimal SI units), and the small but UI-facing change that decimal SI kilobytes (units of 1000 bytes) are given with the symbol "kB" rather than the more ambiguous (and arguably less accurate) symbol "KB". In addition to republishing `bytesize`, `gix-features` also republishes `prodash`. Futhermore, some uses of `bytesize` are transitively through `prodash`, which itself has recently received an update to use `bytesize` major version 2. (Since `prodash` does not republish `bytesize`, that is not considered to be a breaking change in `prodash` itself.) To get the benefits of the newer version of `bytesize` while avoiding new inconsistencies, and also to avoid depending on multiple versions of `bytesize`, the `prodash` dependency version has also been upgraded. For more information, see: - GitoxideLabs#1952 - https://github.com/bytesize-rs/bytesize/releases/tag/bytesize-v2.0.0 - GitoxideLabs#1949 - GitoxideLabs/prodash#33 - GitoxideLabs#1953
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Apr 15, 2025
`gix-features` republishes `bytesize`, which has been bumped from major version 1 to major version 2. Because the interface of `bytesize` is effectively part of that of `gix-features` due to the explicit republication of the `bytesize` module in full (with no documented extra limitations related to interface stability), this is effectively a breaking change in `gix-features` as well, though many callers may not be substantially affected. Major changes that may affect some callers that use `bytesize` through `gix-features` include the removal of the top-level `bytesize::to_string()` function, the change in default behavior from displaying decimal SI units to displaying binary IEC units (though all or most gitoxide-related creates, in adapting to the changes, have thus far opted to continue using decimal SI units), and the small but UI-facing change that decimal SI kilobytes (units of 1000 bytes) are given with the symbol "kB" rather than the more ambiguous (and arguably less accurate) symbol "KB". In addition to republishing `bytesize`, `gix-features` also republishes `prodash`. Futhermore, some uses of `bytesize` are transitively through `prodash`, which itself has recently received an update to use `bytesize` major version 2. (Since `prodash` does not republish `bytesize`, that is not considered to be a breaking change in `prodash` itself.) To get the benefits of the newer version of `bytesize` while avoiding new inconsistencies, and also to avoid depending on multiple versions of `bytesize`, the `prodash` dependency version has also been upgraded. For more information, see: - GitoxideLabs#1952 - https://github.com/bytesize-rs/bytesize/releases/tag/bytesize-v2.0.0 - GitoxideLabs#1949 - GitoxideLabs/prodash#33 - GitoxideLabs#1953
4 tasks
|
Hello, would you publish a new release? I would like to use the latest rustix with gix. |
|
Thanks for the hint - I will do that once #1935 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the cargo group with 3 updates: clap, prodash and rustix.
Updates
clapfrom 4.5.35 to 4.5.36Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
Commits
7a6475echore: Release0266c41docs: Update changelog6ec0b43Merge pull request #5791 from okapia/zsh-default-fallbacke40168cfix(zsh): Use _default as zsh completion fallbackUpdates
prodashfrom 29.0.1 to 29.0.2Release notes
Sourced from prodash's releases.
Changelog
Sourced from prodash's changelog.
Commits
964a86bRelease prodash v29.0.22216036update changelog prior to release4ff81bfMerge pull request #33 from EliahKagan/bump-bytesize61dfa7dBumpbytesizefrom major version 1 to 2Updates
rustixfrom 1.0.3 to 1.0.5Commits
cb01fbechore: Release rustix version 1.0.5310f8ecMark 32-bit x86 freebsd as needing y2038 fixes. (#1430)1997940chore: Release rustix version 1.0.4d2fe327For tidiness, keep thetarget_os = "..."lists sorted alphabetically. (#1429)416b4c3HandleDurationoverflow gracefully inkevent. (#1427)bd5427cFix build, sockopts and examples for cygwin (#1428)92cd57aTemporarily disable x86_64-uwp-windows-msvc in CI due to build errors on nigh...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions