Skip to content

Make mutation in gix_blame::types::UnblamedHunk more idiomatic #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

Make mutation in gix_blame::types::UnblamedHunk more idiomatic #1978

merged 2 commits into from
May 1, 2025

Conversation

@cruessler
Copy link
Contributor

This is a tiny PR that makes 3 methods in gix_blame::types::UnblamedHunk hopefully more idiomatic.

  • Remove obsolete comment
  • Make mutation more idiomatic

Byron
Byron approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better!
And I feel a bit guilty as well to not have seen it in the review 😅.

@Byron Byron merged commit dc3c7c9 into GitoxideLabs:main May 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cruessler @Byron