Stop special-casing RUSTSEC-2025-0021 for cargo deny on CI
#1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tools" This reverts commit 67d9bf4, but not the other changes from GitoxideLabs#1927. `gix-testtools` 0.16.1 has the change in 9b12d50 (GitoxideLabs#1972) from depending on previous SemVer-incompatible versions of `gix-*` crates to depending on the current versions. Since then, nothing affected by https://rustsec.org/advisories/RUSTSEC-2024-0436.html appears in our dependency tree, and it is no longer necessary or desirable to use a more complicated `cargo deny check advisories` scanning approach allowing that advisory through `gix-testtools`.
EliahKagan
changed the title
cargo deny allow RUSTSEC-2025-0021 via gix-testtools"cargo deny on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 67d9bf4, but not the other changes from #1927.
gix-testtools0.16.1 has the change in 9b12d50 (#1972) from depending on previous SemVer-incompatible versions ofgix-*crates to depending on the current versions. Since then, nothing affected by RUSTSEC-2024-0436 appears in our dependency tree, and it is no longer necessary or desirable to use a more complicatedcargo deny check advisoriesscanning approach allowing that advisory throughgix-testtools.The scan looks good. As expected, even without special casing that advisory, the
advisoriescheck passes.Note that this is not related to #1989, except in that they are both unblocked by #1972.