Skip to content

Make justfile clearer and fix some edge cases in the checks #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Make justfile clearer and fix some edge cases in the checks #1994

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aebc335
Change `if ...; then false; else true; fi` to `! ...`
EliahKagan May 5, 2025
ce071bf
Clarify commands where we grep for a warning
EliahKagan May 5, 2025
b8147f4
Harden checks that unwanted dependencies are absent
EliahKagan May 5, 2025
0a43f56
Suppress color in `cargo tree` warnings for simpler grepping
EliahKagan May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,21 @@ check:
cargo check --workspace
cargo check --no-default-features --features small
# assure compile error occurs
if cargo check --features lean-async 2>/dev/null; then false; else true; fi
if cargo check -p gitoxide-core --all-features 2>/dev/null; then false; else true; fi
if cargo check -p gix-packetline --all-features 2>/dev/null; then false; else true; fi
if cargo check -p gix-transport --all-features 2>/dev/null; then false; else true; fi
if cargo check -p gix-protocol --all-features 2>/dev/null; then false; else true; fi
cargo tree -p gix --no-default-features -e normal -i imara-diff 2>&1 | grep warning # warning happens if nothing found, no exit code :/
cargo tree -p gix --no-default-features -e normal -i gix-submodule 2>&1 | grep warning
cargo tree -p gix --no-default-features -e normal -i gix-pathspec 2>&1 | grep warning
cargo tree -p gix --no-default-features -e normal -i gix-filter 2>&1 | grep warning
if cargo tree -p gix --no-default-features -i gix-credentials 2>/dev/null; then false; else true; fi
! cargo check --features lean-async 2>/dev/null
! cargo check -p gitoxide-core --all-features 2>/dev/null
! cargo check -p gix-packetline --all-features 2>/dev/null
! cargo check -p gix-transport --all-features 2>/dev/null
! cargo check -p gix-protocol --all-features 2>/dev/null
# warning happens if nothing found, no exit code :/
cargo --color=never tree -p gix --no-default-features -e normal -i imara-diff \
2>&1 >/dev/null | grep '^warning: nothing to print\>'
cargo --color=never tree -p gix --no-default-features -e normal -i gix-submodule \
2>&1 >/dev/null | grep '^warning: nothing to print\>'
cargo --color=never tree -p gix --no-default-features -e normal -i gix-pathspec \
2>&1 >/dev/null | grep '^warning: nothing to print\>'
cargo --color=never tree -p gix --no-default-features -e normal -i gix-filter \
2>&1 >/dev/null | grep '^warning: nothing to print\>'
! cargo tree -p gix --no-default-features -i gix-credentials 2>/dev/null
cargo check --no-default-features --features lean
cargo check --no-default-features --features lean-async
cargo check --no-default-features --features max
Expand Down
Loading