[WIP] Add commit signing #2208
[WIP] Add commit signing #2208
Conversation
| .extra_headers | ||
| .push((BStr::new(SIGNATURE_FIELD_NAME), extra_header)); | ||
|
|
||
| eprintln!("{commit_ref:?}"); |
There was a problem hiding this comment.
@Byron At this point, I would like to write the signed commit back to the filesystem. I searched the codebase for hints on how this is usually done, but couldn’t really find anything. Would you be able to point me to an example?
There was a problem hiding this comment.
That would be repo.write_object(&commit_ref)?.
It's great you use the commit_ref for this by the way as it means any commit, even somewhat malformed ones, can be signed with this.
There was a problem hiding this comment.
Thanks, that’s what I was looking for! I assume that, once the signed object has been written, rev_spec needs to be made to point to the new commit, and the reflog needs to be updated. Is that what I’d use repo.edit_reference() for?
| .extra_headers | ||
| .push((BStr::new(SIGNATURE_FIELD_NAME), extra_header)); | ||
|
|
||
| eprintln!("{commit_ref:?}"); |
There was a problem hiding this comment.
That would be repo.write_object(&commit_ref)?.
It's great you use the commit_ref for this by the way as it means any commit, even somewhat malformed ones, can be signed with this.
This is a rough, incomplete prototype, mainly intended to allow me to ask a couple of questions on how to implement various things.