hash: Future Proofing - rewritten commits of #2213 #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing a non-additive feature `no_sha1` in the future,
if ever dependents want to build, say, a SHA-256 version only,
anticipate this today by requiring the feature `sha1`. For now,
since this crate is useless without support for SHA-1, omitting
the feature `sha1` results in a compile error. But in the future,
this error could be removed.
Dependents that have `default-features = false` will see breakage,
and they will have to adjust to
default-features = false
features = ["sha1"]
to recover.
This will allow adding other variants, such as for SHA-256, without breaking dependents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the original, see #2213.
It wasn't allowed to push into the existing branch.