Add support for :(optional) prefix for path configuration values
#2283
+232
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Add support for optional prefix in gix-config crate
Add support for Dec 4, 2025
:(optional) prefix for path configuration values
Copilot finished work on behalf of
Byron
December 4, 2025 07:42
…ig-value It's breaking because it adds the `optional` field to the `Path` type. Co-authored-by: Byron <[email protected]>
Byron
force-pushed
the
copilot/add-optional-prefix-support
branch
from
3df2fbb to
c72ea8b
Compare
Byron
reviewed
Dec 4, 2025
Comment on lines
+548
to
+559
| let is_optional = path.is_optional; | ||
| let res = path.interpolate(ctx); | ||
| if is_optional { | ||
| if let Ok(path) = &res { | ||
| // As opposed to Git, for a lack of the right error variant, we ignore everything that can't | ||
| // be stat'ed, instead of just checking if it doesn't exist via error code. | ||
| if path.metadata().is_err() { | ||
| return None; | ||
| } | ||
| } | ||
| } | ||
| Some(res) |
Member
There was a problem hiding this comment.
@copilot Write tests for accessing optional configuration paths, as added here.
Contributor
Author
There was a problem hiding this comment.
Added 4 comprehensive tests for accessing optional configuration paths in commit 4ffcaa4:
optional_path_with_existing_file_is_returned- verifies optional paths with existing files return Some(Ok(path))optional_path_with_missing_file_returns_none- verifies optional paths with missing files return Nonerequired_path_with_existing_file_is_returned- verifies required paths with existing files work correctlyrequired_path_with_missing_file_returns_some_in_lenient_mode- verifies lenient mode behavior
The tests use the trusted_path() method on config snapshots and validate the :(optional) prefix behavior through the trusted_file_path() function. Test fixtures are generated with absolute paths using the make_config_repos.sh script.
…ConfigSnapshot::trusted_path()`. Optional, but non-existing paths are now returned as `None`.
Byron
force-pushed
the
copilot/add-optional-prefix-support
branch
from
c72ea8b to
580bee9
Compare
Member
|
Great basis to build on top of! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for optional path configuration
Added 4 comprehensive tests for accessing optional configuration paths:
✅ optional_path_with_existing_file_is_returned - Verifies that optional paths with existing files return Some(Ok(path))
✅ optional_path_with_missing_file_returns_none - Verifies that optional paths with missing files return None (not an error)
✅ required_path_with_existing_file_is_returned - Verifies that required paths with existing files return Some(Ok(path))
✅ required_path_with_missing_file_returns_some_in_lenient_mode - Verifies that required paths with missing files in lenient mode still return Some(Ok(path))
The tests use the
trusted_path()API on config snapshots and verify the behavior of the:(optional)prefix implementation intrusted_file_path()function.Test fixtures created with absolute paths to ensure proper file existence checking.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.