gix-error punch-through
#2352
Draft
gix-error punch-through
#2352
+815
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Byron
force-pushed
the
gix-error
branch
3 times, most recently
from
759c85c to
238924c
Compare
This will make for easier introspection for users of these errors.
…f4f260121f9f84305 This is the basis for substantial changes to make it usable for the `gix-*` crates. The wonderful aspect about this is not only a great reduction in dependencies, but it also removes most proc-macro invocations.
Byron
force-pushed
the
gix-error
branch
2 times, most recently
from
198fe27 to
59b14fa
Compare
- Top-level `Error` - dissolve `Exn` back to `Box<E>` - Use `dyn Error + Send + Sync + 'static'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
exnforgix-dateFramecan only cast to specific types, not to anything that one of them implements.error_generic_member_accessrust-lang/rust#99301 soon being merged, I think it's not problem to one day provide information through that mechanism.IsSpurioushandles today.exnfor compatibilityError->ErrorExtErroris top-level type-erased errorexnforgix-transportexnfor shortest path of remaining crates togixgix-revisiongixspecial handling/traits re-implemented viaexnNeeded in
exnExn::into_inner()to avoid issues due toExnnot beingErroritself.