-
-
Notifications
You must be signed in to change notification settings - Fork 414
Add a test combining renames and edits on multiple branches #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test combining renames and edits on multiple branches #2366
Conversation
|
@Byron I’m confused. I intentionally committed the archive at |
|
I'm not sure what the minimal amount of cleaning is, for That procedure does work here, and I've opened the "sub-PR" cruessler#1 to offer the regenerated archive from running it, in case you find that useful. (As noted there, regenerating the archive allows all CI checks to pass, as can be verified in EliahKagan@e9ff5de.) |
|
Yes, I think what @EliahKagan shared would be the fix to this. The key here is to remove Edit: I also put it back to draft as long as CI is unhappy. |
Done by running
gix clean -xde
cargo nextest run --workspace --no-fail-fast
on an Ubuntu 25.10 system, and verifying that all tests passed and
that exactly one non-`.gitignore`'d archive was regenerated.
|
@EliahKagan @Byron Thanks a lot to both of you for your help! I think I’m now closer to understanding how generated archives and their caches work. :-) The thing I wasn’t aware of was that I had to delete the |
…ead of `number` This style is used in `gix-diff` already, and I think it's minimal and easy to understand.
|
Thanks a lot! I have altered the 'style' of the text that causes the diffs, and I hope you like it. The idea is: beforeafterThis way, it's clear which line is changed, it's encoded in the change. I'd hope we can refactor other places that can benefit from it as well. |
This PR is related to #2343 and #2308. I’m currently trying to find edge cases where
gix blameandgit blamediverge. This PR is the result of such a search. This specific test unfortunately does not fully capture the real-world case that initially triggered the search. All I know is that I was looking for some combination of a file that gets changed in one branch, gets changed and renamed in a different branch and then goes through a merge commit. This PR’s test case apparently is still missing at least one detail because it passes onmain. I think it’s still useful as a test case as it captures a slightly different scenario than the already existing test case.Details
The edge case I was investigating was the history of
gix-pack/tests/Cargo.tomlleading up to c9275b9.