Remove errant CI step fragment progress-tree"
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fragment, with an unmatched quote, in the "Test (crossterm)" step on in the Windows test job, has been present ever since an attempt to expand what is tested on Windows in b7e0f2c (GitoxideLabs#13). It looks like no tests ever run as part of this step; it may be that the action parses this into something that filters out all tests. This change removes the fragment in the hope to enable some tests.
There was a problem hiding this comment.
Pull request overview
This PR fixes a malformed CI configuration in the Windows test job that has been preventing tests from running properly. The change removes an errant text fragment with an unmatched quote that was causing the test step to filter out all tests.
Changes:
- Fixed the malformed
argsparameter in the "Test (crossterm)" step for Windows by removing the duplicateprogress-tree"fragment and unmatched quote
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fragment, with an unmatched quote, in the "Test (crossterm)" step on in the Windows test job, has been present ever since an attempt to expand what is tested on Windows in b7e0f2c (#13). It looks like no tests ever run as part of this step; it may be that the action parses this into something that filters out all tests. This change removes the fragment in the hope to enable some tests.
Having enabled tests on Windows, this also explicitly skips
render::tuion Windows, since it blocks forever (it never completes), at least as run on CI.