convert_graph_formats() handles networkx nodes that are neither strin…#242
Open
shashank025 wants to merge 1 commit intoGiulioRossetti:masterfrom
Open
convert_graph_formats() handles networkx nodes that are neither strin…#242shashank025 wants to merge 1 commit intoGiulioRossetti:masterfrom
shashank025 wants to merge 1 commit intoGiulioRossetti:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gs nor ints
Identify the Bug
Description of the Change
As mentioned on issue #241, this change handles the scenario where the graph nodes are neither strings nor ints. This is done in two steps:
Alternate Designs
NA
Possible Drawbacks
One issue with this fix is the extra memory required to construct the dictionary. But I don't see a way around this if supporting bipartite graphs is required.
Verification Process
test_utils.py.Release Notes
Correctly handled conversion from networkx to igraph format for bipartite graphs where nodes are neither strings nor ints.