forked from git-bug/git-bug
-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: Snapshot refactoring #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GlancingMind
wants to merge
65
commits into
master
Choose a base branch
from
snapshot-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
31d915c
Hide Snapshot::Title field from public access
GlancingMind 0ad4f36
Hide Snapshot::Status from public access
GlancingMind 3a770aa
Hide Snapshot::Comments from public access
GlancingMind 4b03767
Hide Snapshot::Labels from public access
GlancingMind 188681e
Hide Snapshot::Author from public access
GlancingMind 13da2ab
Hide Snapshot::Actors from public access
GlancingMind afed1de
Hide Snapshot::Participants from public access
GlancingMind 64c5ebe
Hide Snapshot::Timeline from public access
GlancingMind 5275415
Remove TODO proposal
GlancingMind d404a76
Move AddLabel loop into separate function
GlancingMind 2176968
Move RemoveLabel loop into separate function
GlancingMind e175475
Add Snapshot::HasLabel methode
GlancingMind cb7012b
Do not sort labels in ChangeLabelOperation
GlancingMind 9020cdd
Use element instead of index in loops
GlancingMind 0d8c3f9
Add Snapshot::appendTimelineItem methode
GlancingMind 66989cf
Hide Comment::Message from public access
GlancingMind 4fdc3c7
Remove message to prevent following error:
GlancingMind 3b6bdde
Use dedicated mutation functions for comment props
GlancingMind 3781204
Hide Comment::Files from public access
GlancingMind 2d20d6f
Hide Comment::UnixTime from public access
GlancingMind d2c043e
Move Timestamp formatting functions into timestamp
GlancingMind 2e8c47e
Add Snapshot::UpdateComment
GlancingMind 2a23fab
Prevent creation of invalid comments
GlancingMind 9dae188
Implement Comment::Edit
GlancingMind d6b0de5
Implement Comment:Edited()
GlancingMind b8ee0a8
Implement Comment:MessageIsEmpty()
GlancingMind 683e4d1
Removed remains of CommentTimelineItem
GlancingMind 8c74135
Rename Alteration to CommentHistoryStep
GlancingMind 6800587
Access comment properites via methodes...
GlancingMind 28082f5
Fix unit test compilation error
GlancingMind 9d482fe
Make comment history public to prevent this error:
GlancingMind b10f132
Set Comment::LastEdited within Comment::Edit()
GlancingMind 9630ee8
Update comment only after storing current state
GlancingMind 91c3f9f
Rename AddCommentTimelineItem to CommentTimelineItem
GlancingMind 720a6bf
Fix: Update GraphQL to CommentTimelineItem rename
GlancingMind c082e83
Make Commet::History private
GlancingMind b0e7bc4
Fix graphql_test fail of following commit:
GlancingMind 1b98da9
Reintroduce failing test
GlancingMind e1435fb
Let CommentTimelineItem only hold the comments id
GlancingMind 1303efe
Add IsAuthored to TimelineItem interface
GlancingMind b189ae5
Remove pointer reciever from comment methodes
GlancingMind 6201e64
GraphQL: Implement CommentTimelineItems resolve
GlancingMind 7f5392d
Fix OpCreateTest and OpEditCommentTest
GlancingMind c2e4a4f
Remove CreateTimelineItem
GlancingMind 0016839
Fix eslint
GlancingMind 2fef4c2
Fix eslint
GlancingMind 6f21fb4
Remove obsolete check
GlancingMind be58736
Fix termui comment selection
GlancingMind 29c9543
Fix nil pointer error for WebUI
GlancingMind 8af3738
Add Bug::Description to graphql schema
GlancingMind 3b8b6db
WebUI: Add description for bug fragment
GlancingMind c66f7fe
GraphQL: Add remaining fields to Comment type
GlancingMind 510a54c
Resolve Comment and CommentTimelineItem as Comment
GlancingMind 9dfba36
WebUI: Fix display of description
GlancingMind 3fb1037
WebUI: Fix comment counter
GlancingMind 690cf20
Rename timestamp: LastEdit to LastEdited
GlancingMind 31c5f2f
Rename Comment:MessageIsEmpty to HasEmptyMessage
GlancingMind 6bfb32c
Rename CommentHistoryStep to Alteration
GlancingMind 1e02465
Move Comment into separate package
GlancingMind a740229
Add documentation, to regenerate connection files
GlancingMind eae0e37
Let snapshot only hold identity IDs
GlancingMind cf57a15
Backup comment patch
GlancingMind 3814def
Fix: commands/show printing of participants
GlancingMind a2d0a14
Fix: commands/show printing of description
GlancingMind 3eca82a
Fix commands/ls comment counter: off-by-one error
GlancingMind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide a Snapshot::appendTimelineItem method, similar to Snapshot::appendComment.Considerations:1. Operations can still access snapshot::comments, TimelineItems, etc. as they are in the same package. What exactly does implementing this dedicated append-methods improve?2. Maybe put Comments, TimeLine, etc. in their own packages. This packages provide methods to also handle a collection of Comments, TimeLineItems, etc. Then a Snapshot won't have the implementation detail of a Comment collection and their is only way to append to the comment collection. Either through Snapshot.Comments.append() or via Snapshot:appendComment(), which itself will call Comments.append().Update: This might be no longer required. Snapshot could append the TimelineItems (aka. Events) itself to the timeline. E.g. SetTitle will post a the SetTitleTimelineItem itself to the Timeline. Further reducing the Operations logic.