gateware.clockgen: Fix off-by-one error#668
Open
mbikovitsky wants to merge 3 commits intoGlasgowEmbedded:mainfrom
Open
gateware.clockgen: Fix off-by-one error#668mbikovitsky wants to merge 3 commits intoGlasgowEmbedded:mainfrom
mbikovitsky wants to merge 3 commits intoGlasgowEmbedded:mainfrom
Conversation
This addresses GlasgowEmbedded#667.
Previously, the strobe would occur one cycle before the output edge, while in the general case the strobe happens on the same cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #667.
ClockGen.deriveandClockGen.calculateis fixed.stb_randstb_fin the half-frequency special case are fixed to behave identically to the general case.