Include cause exception details in RuntimeError#1
Open
GlenWalker wants to merge 2 commits intomasterfrom
Open
Conversation
If there is any kind of error when importing monotonic a generic RuntimeError is raised, with the description 'no suitable implementation for this system'. We very occasionally see this on a system where monotonic otherwise works correctly. I suspect ctypes.util.find_library is occasionally failing (as it executes ldconfig under the hood), but it is difficult to tell because details of the cause are lost, and replaced with the generic error message. Include details of the cause exception in the RuntimeError description so this information is not lost.
Trimmed extra space from exception message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is any kind of error when importing monotonic a generic RuntimeError is raised, with the description 'no suitable implementation for this system'. We very occasionally see this on a system where monotonic otherwise works correctly. I suspect ctypes.util.find_library is occasionally failing (as it executes ldconfig under the hood), but it is difficult to tell because details of the cause are lost, and replaced with the generic error message. Include details of the cause exception in the RuntimeError description so this information is not lost.