Skip to content

fix(admin-ui): Add full typescript type system for the USERS plugin#2215

Merged
duttarnab merged 12 commits intomainfrom
feat-adminui-2128
Aug 6, 2025
Merged

fix(admin-ui): Add full typescript type system for the USERS plugin#2215
duttarnab merged 12 commits intomainfrom
feat-adminui-2128

Conversation

@syntrydy
Copy link
Contributor

#2128
closes #2128

@syntrydy syntrydy self-assigned this Jul 30, 2025
@syntrydy syntrydy added comp-admin-ui Component affected by issue or PR comp-docker-admin-ui Component affected by issue or PR labels Jul 30, 2025
@mo-auto
Copy link
Member

mo-auto commented Jul 30, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Jul 30, 2025
@duttarnab
Copy link
Contributor

The audit log format on changing password is incorrect

{"headers":{"Content-Type":"application/json"},"userAction":{"client_id":"2001.53d2ca8e-541a-4b20-96df-fe4a71d4079a","status":"success","performedBy":{"user_inum":"4a7b0e05-9564-486b-88df-57b9f62ae049","userId":"Default Admin User"},"action":"UPDATE","resource":"api-users","message":"dsfsfsfssfd","payload":{"inum":"f8850322-ee2e-4db0-85bd-17d66aa3963c","userPassword":"arnab","action_message":"dsfsfsfssfd"},"date":"2025-07-31T17:56:45.079Z"}}

It should be like below

{"headers":{"Content-Type":"application/json"},"userAction":{"client_id":"2001.40675ab3-9bb5-48c0-8e5f-24c1ed8d8d2a","status":"success","performedBy":{"user_inum":"14c90bcc-80ad-41ce-9393-5d134d651c80","userId":"Default Admin User"},"action":"UPDATE","resource":"api-users","message":"qeqweqweqeqe","performedOn":{"user_inum":"51b099db-3891-493f-ac09-3bbb28d68ef9","userId":"arnab"},"payload":{"inum":"51b099db-3891-493f-ac09-3bbb28d68ef9","jsonPatchString":"[]","customAttributes":[{"name":"userPassword","multiValued":false}],"performedOn":{"user_inum":"51b099db-3891-493f-ac09-3bbb28d68ef9","userId":"arnab"},"action_message":"qeqweqweqeqe"},"date":"2025-07-31T17:55:18.611Z"}}

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

@duttarnab
Copy link
Contributor

  1. performedBy is missing
 "performedBy": {
      "user_inum": "14c90bcc-80ad-41ce-9393-5d134d651c80",
      "userId": "Default Admin User"
    },
  1. Password value should not be displayed in logs
"customAttributes": [
        {
          "name": "userPassword",
          "multiValued": false,
          "values": [
            "password" --------------------------> value of password should not be displayed
          ]
        }
      ],

duttarnab
duttarnab previously approved these changes Aug 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

@syntrydy syntrydy requested a review from duttarnab August 5, 2025 09:08
@duttarnab duttarnab merged commit efdc2bf into main Aug 6, 2025
8 checks passed
@duttarnab duttarnab deleted the feat-adminui-2128 branch August 6, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-admin-ui Component affected by issue or PR comp-docker-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(admin-ui): Add full typescript type system for the USERS plugin

4 participants