Skip to content

fix(admin-ui): add Default Acr tab in Authn screen of Admin UI#2262

Closed
faisalsiddique4400 wants to merge 26 commits intomainfrom
admin-ui-issue-2250
Closed

fix(admin-ui): add Default Acr tab in Authn screen of Admin UI#2262
faisalsiddique4400 wants to merge 26 commits intomainfrom
admin-ui-issue-2250

Conversation

@faisalsiddique4400
Copy link
Contributor

@faisalsiddique4400 faisalsiddique4400 commented Sep 3, 2025 •
edited
Loading

fix(admin-ui): add Default Acr tab in Authn screen of Admin UI #2250

🐞 Issue

In TUI, the Auth page includes a Default Acr tab, allowing users to select and save default authentication methods. This functionality was missing in the Admin UI.

🔧 Fix

  • Modify Default Acr tab to the Admin UI's Authn screen, aligned with TUI behavior.
    • Added Script tab to the Admin UI's Authn screen, aligned with TUI behavior.
    • Added LDAP tab to the Admin UI's Authn screen, aligned with TUI behavior.
  • Populated available authentication methods using built-in methods and active person authentication scripts.
  • Ensured values can be saved and reflected correctly in the Auth server properties.

🔗 Ticket

Closes: #2250

@faisalsiddique4400
fix(admin-ui): add Default Acr tab in Authn screen of Admin UI
fb01635 
Implemented the Default Acr tab in the Authn screen, similar to TUI.
Allows users to select and save default authentication methods from available person authentication scripts and built-in methods.
@faisalsiddique4400 faisalsiddique4400 marked this pull request as ready for review September 5, 2025 12:34
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
moabu
moabu reviewed Sep 18, 2025
View reviewed changes
@faisalsiddique4400
Merge branch 'main' into admin-ui-issue-2250
bb9bb2b 
Signed-off-by: Faisal Siddique <71010439+faisalsiddique4400@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Passed Quality Gate passed for 'flex_linux_setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@faisalsiddique4400
Copy link
Contributor Author

faisalsiddique4400 commented Oct 7, 2025 •
edited
Loading

The projects are not coming from the api side.
/jans-config-api/api/v1/agama-repo

Screenshot 2025-10-07 at 7 26 15 PM

@duttarnab
Copy link
Contributor

duttarnab commented Oct 8, 2025

The projects are not coming from the api side. /jans-config-api/api/v1/agama-repo

The issue have been fixed yesterday. I think we need to take the latest and check.

moabu
moabu previously approved these changes Oct 9, 2025
View reviewed changes
@faisalsiddique4400
Copy link
Contributor Author

faisalsiddique4400 commented Oct 9, 2025

On test server the dropdown is not populating agama projects deployed on auth server. (casa agama project is deployed).

image

The issue is fixed. Please check

moabu
moabu previously approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good just fix the conflict.

@faisalsiddique4400
Merge branch 'main' into admin-ui-issue-2250
0905895 
Signed-off-by: Faisal Siddique <71010439+faisalsiddique4400@users.noreply.github.com>
duttarnab
duttarnab requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@duttarnab duttarnab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The branch is throwing error on deployment.
  • Only one tab is added. I think there are redundant changes in many files.

@faisalsiddique4400
Copy link
Contributor Author

faisalsiddique4400 commented Oct 24, 2025

Merge Conflicts Resolved.

@faisalsiddique4400
Copy link
Contributor Author

faisalsiddique4400 commented Oct 24, 2025

  • The branch is throwing error on deployment.
  • Only one tab is added. I think there are redundant changes in many files.

The error is resolved by resolving the errors in the files.
The branch is now working fine on my local.

duttarnab
duttarnab requested changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@duttarnab duttarnab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Only Default ACR tab should be added. Rest of the tabs should be as it is
image
  • Audit log is incorrect
image
  • Remove the redundant changes in the files.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2025

Quality Gate Passed Quality Gate passed for 'Gluu Admin UI'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@faisalsiddique4400 faisalsiddique4400 deleted the admin-ui-issue-2250 branch October 29, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duttarnab duttarnab duttarnab requested changes

@moabu moabu moabu left review comments

@syntrydy syntrydy Awaiting requested review from syntrydy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(admin-ui): add Default Acr tab in in Authn screen of Admin UI as done in TUI

3 participants

@faisalsiddique4400 @duttarnab @moabu