fix(docs): add documentation for SCIM screen on Admin-UI#2273
fix(docs): add documentation for SCIM screen on Admin-UI#2273
Conversation
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
jgomer2001
left a comment
There was a problem hiding this comment.
95% of these contents are b*hit ...
- It is unnecessary to provide justifications for every single property, like "...improves performance, and enables efficient pagination...".
- For some reason, AI infers this is LDAP-centric stuff and mentions "directory" all over the place - this does not hold anymore
I think we can focus on a few properties that are useful. For the rest I ignore if they are used, or what they do. Here is my list:
Base EndpointmaxCountBulk Max OperationsBulk Max Payload SizeUser Extension Schema URILogging LevelskipDefinedPasswordValidation
Here, descriptions given are OK, except for their bias towards LDAP. Also account scim in Jans is not only about users and groups
skipDefinedPasswordValidation determines if the the regex defined at the server level for user passwords should be bypassed or not. This is located in the attributes table (row corresponding to password attr)
Thank you for your honest feedback. AI assisted content generation should be reviewed closely. Let me remove other properties apart from what you listed above. Then I'll need your help to reword it so that LDAP is not in focus. |
@jgomer2001 I didn't get |
|
Probably they are not used. Many of jans apps share the same bootstrapping/initialization code that resides in shared libraries but most of us (devs) are not really familiar with them. It has to do with topics like cache, document store, logging, etc.. Based on past experiences, removing "pointers" to features that are not in use may cause scim not to start properly... So I guess that's why they still remain in the configuration. However, the list I provided contains the set of properties that in practice admins and developers would really like to tweak |
|
I see. So those In this case, I have two suggestions:
Note: If other modules also have the same burden of unused properties on the config screens, this suggestion will apply to those screens as well. |
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
|
@jgomer2001 I have removed the details about less-frequently used properties. Can you please update the descriptions of the remaining properties to effect this part of your comment |
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
|



This PR adds documentation for Admin-UI SCIM configuration screen.
Summary of changes: