fix(admin-ui): rename "Authn" to "Authentication" in menu and page title #2304

[faisalsiddique4400]

fix(admin-ui): rename "Authn" to "Authentication" in menu and page title #2304

Description

This PR updates the label and title “Authn” within the Admin UI sidebar to “Authentication” for improved clarity and user experience. The change ensures consistency across the sidebar menu and page headers.

Summary

• Renamed Authn to Authentication in the sidebar navigation.
• Updated page titles and headers to reflect the new label.
• Updated page titles in agama flows as well.
• Verified visual consistency throughout the Admin UI.

Expected Behavior

Both the sidebar and page title should now display Authentication instead of Authn.

🔗 Ticket

Closes: #2304

Summary by CodeRabbit

• Updates

  • Standardized authentication terminology across menus and page titles in the admin interface.
  • Page titles updated to show "Authentication" consistently.

• Localization

  • Added/updated translation entries so the Authentication label appears consistently across English, French, Spanish, and Portuguese.

[moabu]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Walkthrough

Rename public translation keys from authn to authentication across locale files and update components and plugin metadata to use the new keys; add new French and Portuguese entries and call SetTitle with the new title key in one component.

Changes

Cohort / File(s)	Change Summary
Locale — English & Spanish admin-ui/app/locales/en/translation.json, admin-ui/app/locales/es/translation.json	Renamed keys: menus.authn → menus.authentication and titles.authn → titles.authentication (values adjusted where applicable).
Locale — French admin-ui/app/locales/fr/translation.json	Added menus.authentication, titles.authentication, and tooltips.authentication; added trailing comma in tooltips to accommodate new key.
Locale — Portuguese admin-ui/app/locales/pt/translation.json	Added menus.authentication and titles.authentication entries.
Components — page titles admin-ui/plugins/auth-server/components/Agama/AgamaAliasListPage.js, admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js, admin-ui/plugins/auth-server/components/AuthN/AuthNListPage.js, admin-ui/plugins/auth-server/components/AuthN/DefaultAcr.js	Updated translation keys used for page titles from titles.authn/titles.agama to titles.authentication; added SetTitle import/use where applicable.
Plugin metadata admin-ui/plugins/auth-server/plugin-metadata.js	Updated menu item title key from menus.authn to menus.authentication; removed an unused AuthNListPage import.

Sequence Diagram(s)

sequenceDiagram
    participant C as Component
    participant I as i18n (translation.json)
    participant T as SetTitle (UI header)
    Note over C,I: On component mount
    C->>I: t('titles.authentication')
    I-->>C: "Authentication" (localized)
    C->>T: SetTitle("Authentication")
    T-->>C: Title updated (UI)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Pay attention to:
  • Consistent key spelling across all locale files (authentication vs accidental authentification).
  • Ensure no remaining references to menus.authn or titles.authn in codebase or other locale files.
  • Validate JSON syntax after edits (commas, trailing commas) in modified locale files.

Poem

🐰
Hopped through keys and changed the name,
"Authn" no more — full word to claim.
Menus and titles now sing in tune,
A tidy label beneath the moon.
🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix(admin-ui): rename "Authn" to "Authentication" in menu and page title #2304" is clear, concise, and directly summarizes the primary change in the changeset. It specifically describes the key modification—renaming "Authn" to "Authentication" in both menu labels and page titles—which aligns perfectly with the content of the pull request. The title is appropriately scoped and provides meaningful information about the changeset at a glance.
Linked Issues Check	✅ Passed	The PR fully satisfies the objectives from linked issue #2304. The changes comprehensively replace the sidebar menu label and page titles from "Authn" to "Authentication" by renaming translation keys (menus.authn → menus.authentication and titles.authn → titles.authentication) across all locale files and updating all component files that reference these keys (AuthNListPage.js, AgamaListPage.js, AgamaAliasListPage.js, DefaultAcr.js, and plugin-metadata.js). The consistent renaming across translation files and component usages ensures clear, consistent labeling throughout the Admin UI as required.
Out of Scope Changes Check	✅ Passed	All code changes are directly related to the stated objective of renaming "Authn" to "Authentication" throughout the Admin UI. The changes include translation key updates across multiple locale files, component title updates, and menu configuration updates in plugin-metadata.js. While plugin-metadata.js includes the removal of an unused AuthNListPage import, this is a minor cleanup closely related to the refactoring and does not introduce unrelated functionality or features.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch admin-ui-issue-2304

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a2c804 and 136e640.

📒 Files selected for processing (2)

• admin-ui/app/locales/pt/translation.json (2 hunks)
• admin-ui/plugins/auth-server/components/AuthN/DefaultAcr.js (1 hunks)

🔇 Additional comments (2)

admin-ui/plugins/auth-server/components/AuthN/DefaultAcr.js (1)

32-32: Verify SetTitle is called correctly outside useEffect.

Line 32 calls SetTitle(t('titles.authentication')) at the top level of the component render function, not wrapped in a useEffect hook. This means it executes during every render cycle. In React, side effects like setting the document title should typically be placed in a useEffect hook to avoid performance issues and unintended re-executions.

Please confirm this pattern is intentional or consider wrapping it in a useEffect(() => { SetTitle(t('titles.authentication')) }, [t]) to align with React best practices.

admin-ui/app/locales/pt/translation.json (1)

43-43: Portuguese translations correctly localized.

Both the menus.authentication (line 43) and titles.authentication (line 902) entries have proper Portuguese localization with the value "Autenticação" rather than the English "Authentication". This aligns with the translation key rename from authn to authentication as intended by the PR.

Also applies to: 902-902

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb486a and 9a2c804.

📒 Files selected for processing (8)

• admin-ui/app/locales/en/translation.json (2 hunks)
• admin-ui/app/locales/es/translation.json (2 hunks)
• admin-ui/app/locales/fr/translation.json (2 hunks)
• admin-ui/app/locales/pt/translation.json (2 hunks)
• admin-ui/plugins/auth-server/components/Agama/AgamaAliasListPage.js (2 hunks)
• admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js (1 hunks)
• admin-ui/plugins/auth-server/components/AuthN/AuthNListPage.js (1 hunks)
• admin-ui/plugins/auth-server/plugin-metadata.js (1 hunks)

🔇 Additional comments (10)

admin-ui/app/locales/es/translation.json (2)

644-646: Sidebar label updated correctly

menus.authentication → "Autenticación" aligns with PR objective.

---

938-940: Page title key updated correctly

titles.authentication → "Autenticación" is consistent with components.

admin-ui/app/locales/pt/translation.json (1)

43-45: Sidebar label added

menus.authentication → "Autenticação" looks good.

admin-ui/app/locales/en/translation.json (1)

644-646: Menu key migrated to authentication

menus.authentication → "Authentication" matches plugin metadata and UI usage.

admin-ui/app/locales/fr/translation.json (2)

43-43: LGTM! French menu translation added correctly.

The addition of "authentication": "Authentification" to the menus section correctly translates the new menu label to French and aligns with the PR's objective to rename "Authn" to "Authentication".

---

905-905: LGTM! French page title translation added correctly.

The addition of "authentication": "Authentification" to the titles section correctly translates the new page title to French and aligns with the PR's objective.

admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js (1)

228-228: LGTM! Page title updated to use new translation key.

The page title correctly uses the new titles.authentication translation key, ensuring consistency across the Admin UI as per the PR objective.

admin-ui/plugins/auth-server/components/AuthN/AuthNListPage.js (1)

47-47: LGTM! Page title updated to use new translation key.

The page title correctly uses the new titles.authentication translation key, maintaining consistency with the broader renaming effort across the Admin UI.

admin-ui/plugins/auth-server/components/Agama/AgamaAliasListPage.js (1)

21-21: LGTM! Page title functionality added correctly.

The import of SetTitle and its usage with titles.authentication properly sets the page title for the Aliases page, maintaining consistency with the other authentication-related pages in the Admin UI.

Also applies to: 48-48

admin-ui/plugins/auth-server/plugin-metadata.js (1)

116-116: LGTM! Menu title translation key updated correctly.

The menu title has been correctly updated from menus.authn to menus.authentication, which will display "Authentication" instead of "Authn" in the sidebar navigation. The path and permission remain unchanged, which is appropriate since this is purely a labeling change.

[sonarqubecloud]

Quality Gate passed for 'Gluu Admin UI'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud