Skip to content

admin-ui: Fix menuResolver#2422

Merged
duttarnab merged 1 commit intomainfrom
fixEmptyMenus
Nov 5, 2025
Merged

admin-ui: Fix menuResolver#2422
duttarnab merged 1 commit intomainfrom
fixEmptyMenus

Conversation

@syntrydy
Copy link
Copy Markdown
Contributor

@syntrydy syntrydy commented Nov 5, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved plugin loading flexibility by removing bundling restrictions, enabling broader plugin file compatibility.

@syntrydy syntrydy self-assigned this Nov 5, 2025
@syntrydy syntrydy requested a review from duttarnab as a code owner November 5, 2025 17:51
@syntrydy syntrydy added bug Something isn't working kind-bug Issue or PR is a bug in existing functionality labels Nov 5, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 5, 2025

📝 Walkthrough

Walkthrough

Removed the webpackInclude filter from two dynamic import calls for plugin-metadata in PluginMenuResolver.js. This eliminates the previous file-matching constraint that restricted bundling to plugin-metadata files with .js or .ts extensions within non-slash paths.

Changes

Cohort / File(s) Summary
Plugin metadata import configuration
admin-ui/plugins/PluginMenuResolver.js
Removed webpackInclude filter from two dynamic import statements for plugin-metadata, expanding bundling flexibility

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify webpack bundling behavior remains correct after filter removal
  • Confirm plugin-metadata file resolution still functions as expected
  • Check if original filter was added for a specific reason or constraint that may need documentation

Poem

🐰 A filter removed, the path grows wide,
Plugin metadata roams with fewer ties,
Webpack bundles dance, no longer confined,
Flexibility blooms in the code we find! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'admin-ui: Fix menuResolver' is vague and does not clearly communicate what specific issue is being fixed or what the actual change entails. Provide a more descriptive title that explains the specific fix, such as 'admin-ui: Remove webpackInclude filter from plugin-metadata imports' to clarify the nature of the fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixEmptyMenus

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9008008 and c380c67.

📒 Files selected for processing (1)
  • admin-ui/plugins/PluginMenuResolver.js (0 hunks)
💤 Files with no reviewable changes (1)
  • admin-ui/plugins/PluginMenuResolver.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: sonar scan (flex-linux-setup)
  • GitHub Check: Analyze (javascript)

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 5, 2025

@mo-auto mo-auto added the comp-admin-ui Component affected by issue or PR label Nov 5, 2025
@duttarnab duttarnab merged commit c2975e2 into main Nov 5, 2025
10 checks passed
@duttarnab duttarnab deleted the fixEmptyMenus branch November 5, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants