Skip to content

fix: remove extra apiVersion#2436

Merged
moabu merged 1 commit intomainfrom
fix-helm-secret
Nov 10, 2025
Merged

fix: remove extra apiVersion#2436
moabu merged 1 commit intomainfrom
fix-helm-secret

Conversation

@misba7
Copy link
Contributor

@misba7 misba7 commented Nov 10, 2025

closes #2435

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Removed duplicate configuration entry in the secret manifest template to prevent potential deployment conflicts.

Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7 misba7 requested review from iromli and moabu as code owners November 10, 2025 16:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

A duplicate apiVersion: v1 declaration is removed from the Helm Secret manifest template, leaving a single valid API version reference.

Changes

Cohort / File(s) Summary
Helm Chart Template Fix
charts/gluu-all-in-one/templates/secret.yaml
Removed duplicate apiVersion: v1 line from Secret resource manifest

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A Secret so cluttered with versions two,
Now cleaned up with care—fresh and new!
One API to rule them all, you see,
Duplicates banished—now that's tidy! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove extra apiVersion' directly and accurately describes the main change of removing a duplicate apiVersion line from the YAML manifest.
Linked Issues check ✅ Passed The pull request successfully addresses issue #2435 by removing the duplicate apiVersion declaration from the secret.yaml template, meeting the stated objective.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly related to fixing the duplicate apiVersion in the YAML file as specified in the linked issue; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-helm-secret

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6bc2f5 and 205d02d.

📒 Files selected for processing (1)
  • charts/gluu-all-in-one/templates/secret.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • charts/gluu-all-in-one/templates/secret.yaml

Comment @coderabbitai help to get the list of available commands and usage tips.

@misba7 misba7 requested review from moabu and removed request for moabu November 10, 2025 16:31
@mo-auto mo-auto added comp-charts-flex Touching folder /flex-cn-setup/pygluu/kubernetes/templates/helm kind-bug Issue or PR is a bug in existing functionality labels Nov 10, 2025
@moabu moabu merged commit 7cd9d77 into main Nov 10, 2025
9 checks passed
@moabu moabu deleted the fix-helm-secret branch November 10, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-charts-flex Touching folder /flex-cn-setup/pygluu/kubernetes/templates/helm kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(helm): remove extra apiVersion in yaml file

3 participants